Samuel Weirich

Results 136 comments of Samuel Weirich

@Arthurk12 What has been the motivation behind this PR? Is is considered for Streaming a BBB Session where no user input is possible? If so, how about also hiding polls,...

I'm happy to do a PR, but first I'd like to see if the current maintainers support this direction. @DeepDiver1975 What do you think?

You can find my WIP here: https://github.com/jumbojett/OpenID-Connect-PHP/compare/master...SamuelWei:OpenID-Connect-PHP:refactor-jwt The code needs to be restructured a bit more, due to large blocks of code duplication. **Currently working / refactored:** - authenticate -...

@DeepDiver1975 Should we also check the iat value? This is currently done in [verifyLogoutTokenClaims](https://github.com/jumbojett/OpenID-Connect-PHP/blob/master/src/OpenIDConnectClient.php#L540) The statement there checks if to issued at timestamp is not too far in the future....

Currently all timestamp checks are compared with $leeway; That has a fixed value and a getter, but no setter. Maybe you could create a PR with a setter !?

> A configurable leeway will also fix this issue [#379](https://github.com/jumbojett/OpenID-Connect-PHP/issues/379). Done: https://github.com/jumbojett/OpenID-Connect-PHP/pull/483