Sam Powell comments

Results 71 comments of


                                            Sam Powell

What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present

We should surely enforce that only one is present?

What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present

@dboas if we specify that only one should be present, then compliant software will never write both to a file, and hence the user will never encounter this problem, right?

What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present

> Presently they both indicate that they are required if the other is not present. It might be a touch enigmatic but surely this is sufficient insofar as it is...

What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present

@dboas @sstucker for the purpose of simplifying parsing, perhaps the human readable part could be parenthesised, e.g., `Presence: required if measurementLists is not present (but should not be present if...

What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present

I think this is true @dboas and indeed an exclusive OR operator such as you propose makes sense. Maybe ^ is a good option given it is a (bitwise) XOR...

[Suggestion] Making CoordinateSystem mandatory if Pos3D is present

> Have the coordinate system be mandatory if sourcePos3D and detectorPos3D are present. I expect that the _vast_ majority of fNIRS recordings are made in some arbitrary space with landmarks...

[Suggestion] Making CoordinateSystem mandatory if Pos3D is present

I expect the result will be that the vast majority of SNIRF files will then feature a co-ordinate system specified as 'other'. Perhaps it would be useful to be more...

[Suggestion] Making CoordinateSystem mandatory if Pos3D is present

I don't object to some explanatory text being added whilst we await the capability to enforce as desired.

[Suggestion] Increased compatability for mutliple AUX data channels to be stored in a single AUX block

@DamianNeurode for the time axis "an array of length is allowed where the first entry is the start time and the second entry is the sample time spacing in TimeUnit...

[Suggestion] Increased compatability for mutliple AUX data channels to be stored in a single AUX block

If an example were provided of multi-channel data with these characteristics then it would certainly be worth further consideration. I would want to be convinced that there was a fairly...