mini-diary
mini-diary copied to clipboard
samuelmeuli
Implement multiple entries per day
This PR has the changes required to allow multiple entries per day. See Issue #96 It handles -
- Search
- Import/export feature
- Migration (from older file containing one entry)
Exporting with this PR results in the same date appearing multiple times if there are multiple entires in a single day. I think the right way would be for the date to only show up once in the case of multiple entries. This occurs with all export formats.
Monday, 14 December 2020
Event 1
Details of event 1
Monday, 14 December 2020
Event 2
Details of event 2
vs
Monday, 14 December 2020
Event 1
Details of event 1
Event 2
Details of event 2
I think it makes sense for pdf and md exports but I am not sure about json and txt formats as these (json and txt) formats are being used to import exported files from other apps (DayOne and jrnl).
@ra314 have you tried importing the format you suggested to see if it fails any tests or breaks anything?
Ah that makes sense. I was only coming at it from an aesthetic point of view and didn't consider json and txt. I agree that it doesn't make sense to do that for the JSON or txt formats since they include timestamps.
@vaibhawj I think making this change just to the pdf and markdown formats as you said would be an improvement.