Sam Maddock
Sam Maddock
I'm currently awaiting comments on my RFC which would unblock this https://github.com/electron/rfcs/pull/4
I had a bug in the code which was trying to get the active tab from the window of the MV2 background page. I updated the code to get the...
Do you recall any steps to reproduce this issue?
Please include details about which extensions were tested and what functionality was missing.
Looking at the call stack, I'm not seeing where a frame is being created in `WebContents::FindReply`. Is this part of a fork? ``` Electron Framework content::RenderFrameHostImpl::GetFrameTreeNodeId() const frame_tree_node.h:141 Electron Framework...
I'd be in favor of adding deprecation warnings now (2) as to give developers and library authors the most time to migrate.
Looks like the menu bar is expecting a different amount of children after this PR https://github.com/electron/electron/blob/4367c5ad9e44ec6f4464cdd7a08a0e447203d21b/shell/browser/ui/views/root_view.cc#L92-L98
Same results on Windows 10 ``` Processor 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz 1.80 GHz Installed RAM 32.0 GB (31.7 GB usable) Device ID C00D9FC1-7D37-46EC-A7CD-92A0D8930D77 Product ID 00329-00000-00003-AA229 System...
> Would it be possible to merge this as it currently is and I'd do the documentation change as a separate PR? Unfortunately the organisation marked the fork repository as...
Hi @YuriL180821, I wanted to see if you'd be interesting in continuing to move this PR forward. I can bring it up to be discussed within the Electron API Working...