Sam Maddock

Results 115 comments of Sam Maddock

@MarshallOfSound Agreed on `e clean` not feeling quite right. It was mostly chosen to avoid analysis paralysis. I think I was considering `artifacts/` to be something broader than only PR...

Reverting to the previous Chromium 138 build due to memory pressure issues with the 139 build. Updated patches for 139 are backed up in [roller/chromium/main-139-backup](https://github.com/electron/electron/compare/roller/chromium/main-139-backup?expand=1).

Electron's [session.getAllExtensions](https://www.electronjs.org/docs/latest/api/session#sesgetallextensions) contains this information. Is there anything missing from that API?

> That doesn't trigger when you press the "install in X" button. The [session 'extension-loaded' event](https://www.electronjs.org/docs/latest/api/session#event-extension-loaded) should be emitted whenever an extension is loaded into the session. This will be...

@FormalSnake If you have interest in contributing to the Electron project, this would be an approachable first-issue for doing so. Chromium has a C++ class called `content::RenderFrameHost` which contains the...

> But isn't an alternative to use the image address and download that in the background to "simulate" the effect? That's one possible approach, but will fail in cases where...

lgtm! If you have the appetite to contribute the code changes as well, the process for building Chromium is fully documented here: https://www.electronjs.org/docs/latest/development/pull-requests The whole set of changes would only...

> I would love to, but c++ development is not really my cup of tea. I will give it a try but I cannot guarantee anything The most painful aspect...

> I do not have enough storage on my laptop, and I have no extra drives sadly Ah, that is a requirement unfortunately. It's close to 100GB between the source+build...

> [@samuelmaddock](https://github.com/samuelmaddock) were you able to confirm it works on other platforms? I can confirm tracing still works on Windows.