Sam Maddock

Upgrading TypeScript from 2.5.3 to 2.8.3 fixed the following error for me ``` TypeError: compiler.createWatchProgram is not a function ``` same as what @kevupton reported.

> So if an iframe opens a child window. `childWindow.webContents.opener` will point to `windowOwningIframe` not the `iframe` itself? `opener` returns an instance of `RenderFrameHost` which would be an iframe in...

> This seems kind of minimally useful on the renderer side, as it's not really trustable. Does `GetLastCommittedOrigin` on the browser side fulfill a similar purpose? https://source.chromium.org/chromium/chromium/src/+/main:content/public/browser/render_frame_host.h;l=518;drc=fa230cce5395b280afd13ae362eabd0a680fc72a The use case...

Hey @mafintosh! I spent some time looking into this and although I don't have a solution for you, I believe this is the entry point where source maps are initiating...

> Is there any news on electron's support for injecting JS into service worker contexts? Currently no update. I've spent time researching what it would take and the amount of...

I think the idea of exposing an API for creating custom UIs is fine. This is obviously more work though for users of the library. Are there certain features lacking...

The ['browser-action-popup-created' event](https://github.com/samuelmaddock/electron-browser-shell/tree/master/packages/electron-chrome-extensions#event-browser-action-popup-created) is emitted once one is created. Would it be possible for you to adjust the position within an event listener? Alternatively, logic to check the container bounds...

Happy to accept contributions for this support. Currently it's an open todo in the code: https://github.com/samuelmaddock/electron-browser-shell/blob/c47bcb3c7a1ff274b469ecffb25245cf580e5811/packages/electron-chrome-extensions/src/browser/popup.ts#L185-L193

Last time I checked, I was able to get it to work with a Japanese dictionary and the in-page floating popup would appear as expected. Did you have luck getting...

Hi @Pranav2612000. You're welcome to fork this repository and submit a pull request with your changes. If you do, it'd be great if the functionality could have a test written...