Samuel Karp
Samuel Karp
> we are in a custom kubernetes scenario. for this, we did some modification in kubelet. I'm not really in favor of modifying containerd in order to support custom forks...
The [`Dockerfile`](https://github.com/google/oss-fuzz/blob/master/projects/containerd/Dockerfile) in oss-fuzz pulls in [the `instrumentation` repo](https://github.com/google/oss-fuzz/blob/1c2f4663eff06a31616b3ebb85f0c73f177a3b9d/projects/containerd/Dockerfile#L20C1-L20C82) and then runs a script which [invokes another script](https://github.com/google/oss-fuzz/blob/master/projects/containerd/build.sh#L18) held in [this repository](https://github.com/containerd/containerd/blob/536608ef227e0825c7c49d59a71a698cc8039ff5/contrib/fuzz/oss_fuzz_build.sh). Can we remove the indirection in the oss-fuzz...
The use of `instrumentation` is not versioned at all. This can be helpful for the evolution of fuzzers, but introduces risk of breakage into our CI (i.e., cloning HEAD is...
Do you have specific use cases for XZ and bzip2? Same as discussed before (https://github.com/containerd/containerd/pull/10241#discussion_r1607092771), I'd prefer to avoid new dependencies (`compress/bzip2` and the `xz` CLI) unless we have specific...
@jonathanmetzman I'd like to see this running with the corresponding change https://github.com/containerd/containerd/pull/10348 before approving. Thanks!
Just as a note here, @kolyshkin we'll probably need a new [Project proposal](https://github.com/opencontainers/tob/blob/main/CHARTER.md#2-oci-projects) for a factored-out cgroups library like we have previously done for the [go-digest](https://github.com/opencontainers/tob/issues/21) and [selinux](https://github.com/opencontainers/tob/issues/27) libraries. I'm...
/cherrypick release/1.7
/cherrypick release/1.6
@dmcgowan It looks like you implemented this in https://github.com/containerd/containerd/pull/8676, and @fuweid addressed the concern about temp mounts in https://github.com/containerd/containerd/pull/10274. Is there anything else to do here besides documentation?