indexmenu icon indicating copy to clipboard operation
indexmenu copied to clipboard

nsort sorts namespaces and pages together

Open rolfik opened this issue 10 years ago • 8 comments

When nsort sorting option is switched on, namespaces and pages on the same index level are sorted together. I use it with msort option as well. Original behaviour sorted namespaces first and then sorted pages were added. Maybe new sorting option can be added for this mode.

rolfik avatar Oct 11 '14 15:10 rolfik

Thanks for this great addition! There have been a couple of requests for this in the issues/disscussion, so users of the indexmenu will appreciate it. e.g. #66

I think this is worth an sorting option. Not every one needs always sorting the dirs and the files together. This is useful for the backward compatibility as well.

I expect that the performance will not derogate too much, but did you test this maybe with some larger data sets already?

Klap-in avatar Oct 11 '14 16:10 Klap-in

I have not tested the performance much. Anyway some property like IsDirectory would help on items instead of searching directories array.

rolfik avatar Oct 12 '14 06:10 rolfik

Is there any chance that this PR gets merged in the official master?

e-dschungel avatar Aug 10 '16 09:08 e-dschungel

This would sure be a nice improvement for those working with "book" and "chapter" formats.

rgleason avatar Dec 06 '16 01:12 rgleason

I still need to test this, for some different situations.

If others have time for testing, please be welcome to do and report what you test and whether the results were like your expectations.

Klap-in avatar Dec 06 '16 13:12 Klap-in

FWIW, I applied this to my installation and it works like a charm, thank you!

What I did:

  • Change to lib/plugins/indexmenu
  • Download this MR as a patch using wget by appending .patch to this URL: wget https://github.com/samuelet/indexmenu/pull/111.patch
  • Apply it with patch -p1 < 111.patch

AndreKR avatar Jan 19 '19 22:01 AndreKR

Which version is your installation?

rfertig avatar Jan 19 '19 23:01 rfertig

FWIW, I applied this to my installation and it works like a charm, thank you!

What I did:

* Change to `lib/plugins/indexmenu`

* Download this MR as a patch using wget by appending `.patch` to this URL:
  `wget https://github.com/samuelet/indexmenu/pull/111.patch`

* Apply it with `patch -p1 < 111.patch`

Thanks for the advice. I would like to add, that the options nsort AND tsort have to be switched on for this to work (tested with the current release 'Hogfather').

g-wenzel avatar Feb 22 '22 20:02 g-wenzel

@rolfik Thanks for contributing this long time ago and your patience! I have implemented it manually due to conflicts with the changes by @eduardomozart due to conflicts.

Klap-in avatar Jan 04 '24 16:01 Klap-in