sentry
sentry copied to clipboard
Change cli
Move from OptionParser to Cli for better integration
class Watch < Sentry::SentryCommand
command_name "watch"
def run
options.watch << "./config/**/*.cr"
super
end
end
When someone runs the install.rb script to install the cli tool it is copying the src files. You are adding a file to the src directory so you will probably need to update install.rb.
Also, the current CLI installation process does not use shards or dependencies, so we will need to figure that out. Correct me if I'm wrong, but I don't believe shards has support for installing CLI tools as a dependency.
I updated the install.rb file to take in account the modifications. ( I completely forgot it 😝 )
Seeing as this will introduce a dependency, is there a way to install Sentry while installing dependencies at the same time? Does shards support that feature? I like what you did to install.rb btw.
Also they way you are loading the app name in the CLI dynamically is a no brainer. 👍 That will be much better. Glad I could get some other eyes on this project to help button it up.
I would however make the DEFAULT_NAME start as nil and print an error if it is not set manually or found in shard.yml.
You may want to look at Admiral as well: https://github.com/jwaldrip/admiral.cr