sentry icon indicating copy to clipboard operation
sentry copied to clipboard

dev directory not cleaned up

Open jgillich opened this issue 4 years ago • 1 comments

The install script creates a dev directory with the Sentry code and never cleans it up. I also think a different more random name would be better since dev is an incredibly common word.

I could submit a PR if that's cool with you.

jgillich avatar Nov 25 '19 05:11 jgillich

sorry. finally responding to old issues.

Well, there are a few common scenarios where you wouldn't want to delete the sentry source files. The source files can be used to generate a new sentry executable if you want to develop on a different machine or in a VM.

Personally, I develop in Docker on a Mac, so I download Sentry on my Mac, and then pass the dev folder into Docker and recompile Sentry from within docker. The executable that Crystal generated on my mac wouldn't be usable within docker, and I wouldn't have the source files to generate a new one.

I could have it part of my docker image to always download the latest sentry version, but thats not as clean as having working source code already in the image.

samueleaton avatar Aug 16 '20 00:08 samueleaton