sentry icon indicating copy to clipboard operation
sentry copied to clipboard

Missing version on shard.yml

Open faustinoaq opened this issue 6 years ago • 9 comments

Hi @samueleaton

I see you released sentry v0.3.0, although, shard.yml still says v0.2.0, see: https://github.com/samueleaton/sentry/blob/v0.3.0/shard.yml#L2

Can you delete v0.3.0 and create it again including the version change on shard.yml?

faustinoaq avatar Jun 21 '18 10:06 faustinoaq

fixed. thanks for keeping me in line. do you know what the standard practice is for other Crystal projects so there is less human error?

samueleaton avatar Jun 21 '18 15:06 samueleaton

@samueleaton Sure, I use shard check on CI to ensure all dependencies tags are ok :wink:

faustinoaq avatar Jun 21 '18 16:06 faustinoaq

@samueleaton Oh, I''m getting this error now: (no idea why :sweat_smile: )

myapp1 git:(master) ✗ shards                
Fetching https://github.com/faustinoaq/sentry-run.git
Fetching https://github.com/samueleaton/sentry.git
Failed git ls-tree -r --full-tree --name-only v1.0.0 -- shard.yml (). Maybe a commit, branch or file doesn't exist?

I'm using sentry as dependency here:https://github.com/faustinoaq/sentry-run/

faustinoaq avatar Jun 21 '18 16:06 faustinoaq

I already cleaned up my shards cache :sweat_smile:

faustinoaq avatar Jun 21 '18 16:06 faustinoaq

do you think if i bumped the minor version it would fix it?

samueleaton avatar Jun 21 '18 17:06 samueleaton

@samueleaton So weird, you have tagged sentry correctly, I checked twice :sweat_smile:

I tried to test only sentry as dependency (without sentry-run) and I still got this error:

➜  ~ crystal init app app02
    create  app02/.gitignore
    create  app02/.editorconfig
    create  app02/LICENSE
    create  app02/README.md
    create  app02/.travis.yml
    create  app02/shard.yml
    create  app02/src/app02.cr
    create  app02/src/app02/version.cr
    create  app02/spec/spec_helper.cr
    create  app02/spec/app02_spec.cr
Initialized empty Git repository in /home/main/app02/.git/
➜  ~ cd app02 
➜  app02 git:(master) ✗ nano shard.yml 
➜  app02 git:(master) ✗ shards
Fetching https://github.com/samueleaton/sentry.git
Failed git ls-tree -r --full-tree --name-only v1.0.0 -- shard.yml (). Maybe a commit, branch or file doesn't exist?

@ysbaddaden any idea what is happening here? :sweat_smile:

faustinoaq avatar Jun 21 '18 17:06 faustinoaq

I just found the issue (mentioned by @hmans on gitter)

@samueleaton You have a 1.0.0 tag here: https://github.com/samueleaton/sentry/releases/tag/1.0.0

Can you remove it? :sweat_smile:

faustinoaq avatar Jun 23 '18 01:06 faustinoaq

I ended up forking this repo and removing the 1.0.0 tag from my fork, so I can confirm this will fix the issue.

hmans avatar Jun 23 '18 05:06 hmans

Can you open an issue in Shards about this? It shouldn't be confused by tags that don't start with v :-/

ysbaddaden avatar Jun 23 '18 07:06 ysbaddaden