rtoml icon indicating copy to clipboard operation
rtoml copied to clipboard

Build amd64 wheels for windows

Open Cranyozen opened this issue 1 year ago • 8 comments

This is a great project, I like it! It would be nice if the releases can contain amd64 wheels for windows too. Otherwise setuptools-rust must be present to continue the installation.

Cranyozen avatar Dec 31 '23 09:12 Cranyozen

PR welcome to add it.

By the way, setuptools-rust isn't used, and maturin will be installed as a build requirement. The only external dependency is the rust toolchain.

samuelcolvin avatar Dec 31 '23 10:12 samuelcolvin

maybe fixed with https://github.com/samuelcolvin/rtoml/pull/75 ?

the build wheels pipeline CI / build os is skipped, so i can't check which wheels are created

zerocewl avatar Jan 23 '24 17:01 zerocewl

Seems to be fixed with #75, the pipeline contains now ...win_amd64.whl wheels again.

https://github.com/samuelcolvin/rtoml/actions/runs/7672121379/job/20911941988

  Compiling pyo3-build-config v0.20.0
   Compiling pyo3-ffi v0.20.0
   Compiling pyo3 v0.20.0
   Compiling rtoml v0.10.0 (D:\a\rtoml\rtoml)
    Finished release [optimized] target(s) in 14.90s
📦 Built wheel for CPython 3.11 to dist\rtoml-0.10.0-cp311-none-win_amd64.whl

Wheels should be part of the next release.

zerocewl avatar Jan 29 '24 07:01 zerocewl

Any updates on when this will be released? I'm stuck on a machine where I am unable to install rust.

mirrorcoloured avatar Mar 28 '24 21:03 mirrorcoloured

I think it would be very good if there could be a new rtoml release made which includes the wheel for 64-bit Windows. I have started to get bug reports in https://github.com/hdl-registers/hdl-registers about pip install failing on Windows due to the dependency.

There are currently 322 projects on GitHub alone that use rtoml (https://github.com/samuelcolvin/rtoml/network/dependents). Releasing rtoml with Windows64 support reinstated would save a lot of confusion and bug reports.

LukasVik avatar Apr 02 '24 14:04 LukasVik

I would like to second @LukasVik's request for another release to fix 64bit Windows installs. I am giving a tutorial on my package that depends on rtoml in a couple of weeks and it would be a lot better if my Windows users could install and update without issues or workarounds.

mtessmer avatar Apr 23 '24 18:04 mtessmer

I also want to point out that there is no earlier version of rtoml for Python 3.12 on Windows. This means Python 3.12 users on Windows can't install rtoml without installing rust and Visual C build tools. This is likely a large hurdle for beginners and so all 322 packages that depend on rtoml are effectively broken for new users on Windows.

mtessmer avatar May 01 '24 20:05 mtessmer