Samuel Colvin

Results 1016 comments of Samuel Colvin

Thanks so much for the explanation @dmontagu, makes sense. I'm very very unwilling to mess with dataclasses again on v1 unless absolutely necessary. Every change we've made has broken something...

Great response, thanks so much for understanding.

> TBH I feel `functools` is broken here and we are just adding a workaround. Even a `lambda` gets an `__qualname__` agreed. Feel free to create an issue on cpython...

Please change the PR body to remove the default text and mention the issue you're closing.

Okay, well adding pypy to tests will be more work than this, but good it works for this feature. Remove pypy for now and we can add it in a...

Sorry about that, I got the impression work here had stopped. But I agree that we should be careful to keep discussions public, sorry.

> Subclassing SecretStr instead of using Annotated appears to give better results. but does this actually apply length validation? I suspect that truth is we won't be able to make...