Samuel Colvin

Results 1016 comments of Samuel Colvin

What @Smixi is saying makes complete sense - there's no infinite recursion going on here (hence why it works for you with fewer members of the union), just that we...

Even better fix for this - use a discriminator on the union, this both avoids the recursion error and will provide an up to 50x improvement in performance - Pydantic...

Weird, I thought I saw the `RecursionError` stop with use of a discriminator, must have been my mistake. --- Ye, I think the issue here is the slow building of...

PR welcome to try that. My guess is that given the complexity of the schema building logic, it will be very hard to be certain we're resolving all references -...

pydantic v1 should be built with cython 0.29: https://github.com/pydantic/pydantic/blob/8822578619bf8d0bb754b1cf7a2a905b50240d01/requirements.txt#L3

makes sense. @hramezani could you work on another patch release using the right cython when building.

Hi, I've tried to reproduce this using and `x64_64` instruction set using gitpod (I'm on an M1 mac today), and I can't reproduce it. Output of `python -c "import pydantic.utils;...

I also tried running pydantic 1.10.13 inside alpine inside gitpod to use musl binaries, and again - no error.