Samuel Colvin

Results 1016 comments of Samuel Colvin

Thanks again for your work @DanielRosenwasser, closing as per my comments above.

not a big worry if this isn't possible since I can use `# noqa: Q000` in the few places where this happens.

Ye, I've seen this too, a partial answer will be the new jiter JSON parser, but even that right now requires you to read the entire JSON into memory, but...

> A property to collect the errors on LenientList would be very handy, so they can be logged for later inspection. collecting errors should become possible in V2 with `context`,...

@Bobronium it should be possible now using [`__get_pydantic_validation_schema__`](https://github.com/pydantic/pydantic/blob/afff676c03838cfbc948ad8217f969f686d7796a/pydantic/_internal/_generate_schema.py#LL86C49-L86C49), any chance you could try it out? PR welcome to add this type for V2.

No hurry, some time before the end of March would be great.

It's also supported out of the box in pydantic-core, see a test example [here](https://github.com/pydantic/pydantic-core/blob/43aa422a47b945516784a907bdc9e64344934333/tests/validators/test_list.py#L173-L185) and the schema to configure it [here](https://github.com/pydantic/pydantic-core/blob/43aa422a47b945516784a907bdc9e64344934333/pydantic_core/core_schema.py#L2237). I implemented this months ago thinking of this issue,...

Sounds good to me 👍 PR welcome. It should be fairly easy to copy other sources. Is there good documentation on the AWS side?

Well probably because of unexpected low system resources causing the slower execution. PR welcome to fix this.