Samuel Colvin comments

Results 1016 comments of


                                            Samuel Colvin

load_alias and dump_alias

I'm not sure on the progress with aliases in pydantic, most likely it just needs wiring together. Serialisation aliases (and indeed serialisation in general) hasn't been released in core, should...

X | Y union syntax breaks GenericModel

Confirmed, should be fixed in V2, @dmontagu might be worth checking this is fixed in #4970. Happy to review a PR to fix this in V1.10, but I suspect it's...

Context when validating data

Thanks should be entirely possible for a wrap validator to alter/inject context which is then accessible by deeper validators. But I guess there's no test for it at present. Happy...

mro problem when building Config in complex model inheritance

Fixed in V2 as we no longer allow config as a class. No work around that I know of.

Feature Request: Clearer errors with variable prefix included

Agreed. Perhaps related to pydantic/pydantic#1094. I also want to always add the value which failed validation to the error context even if it's not rendered. (Though I know that's not...

Extend RedisSettings to include redis Retry Helper settings

@JonasKs @Kludex we might be able to use redis's retry logic to remove our retry stuff - https://github.com/samuelcolvin/arq/blob/94cd8782b4f0764a17962186a349d32125cb98e3/arq/connections.py#L258-L286

Extend RedisSettings to include redis Retry Helper settings

`v0.26.0b1` is released, please try it, I'll release `v0.26` at the end of the week, see #441.

Enforce using typing_extensions.TypedDict for Python < 3.11

I don't think the middle option works - could be too confusing. We either go for least effort, or go the whole hog and respect both `Required`s. Happy to do...

Enforce using typing_extensions.TypedDict for Python < 3.11

Yes, please create an issue now. Assuming this is complete, I'll review it soon.

Take a `mode` parameter in `validate_python`

Welcome @DanielRosenwasser and thanks for the PR, kudos for trying. > Or perhaps a better question - what doesn't work with the current PR? The problem is we have specific...