Samuel Colvin

Results 1016 comments of Samuel Colvin

Off the top of my head, I don't know. That's a config setting called `copy_on_model_validation` try setting it to false and seeing if that avoids a copy that causes the...

1.9.1 hasn't changed `smart_deepcopy` so that wouldn't make a difference. Really I don't think it's correct for the sqlalchemy type to be raising an error on `__bool__`, but I get...

That doesn't work, `None` is already covered by the `IMMUTABLE_NON_COLLECTIONS_TYPES` check above, and this line is using falsy as a proxy for empty on iterable types, so a `None` check...

I'm not sure what you mean, but neither of your code suggestions will work. Best to try it and see what happens.

I think this is great but we need: * a prominent `!note` in the docs explaining this * a `**breaking change:**` prefix on the description

Looks good to me, but sadly this has some fairly complicated conflicts.

Wow this is old :see_no_evil:. @PrettyWood what do you think? V1.10, V2 or close.