Samuel Colvin

LGTM, please add a change description.

please update.

thanks so much.

Yes, we use the standard dataclass initialisation to resolve args and kwargs, then do validation, thus aliases can't be used because dataclasses don't know how to handle them. This is...

Happy to review a PR, hard to know how clean/performant it would be until someone tries it.

Not yet. I think we still need to decide on exactly how it would work. Questions: * I think it would be good if this could be done via one...

I think that's uglier than the decorator approach outlined above.

please update.

Thanks so much for the benchmarks, I think we should go with `from urllib.parse import quote_plus` for the following reasons: * keep it simple, minimise our own logic * I...

Also, @FaresAhmedb please remember to use the magic comment "please review" (with one space) to request a review, otherwise we might miss updates on the PR.