Samuel Colvin comments

Results 1016 comments of


                                            Samuel Colvin

Allow for passing keyword arguments to from_orm

I'll try to merge for v1.10 soon.

Allow for passing keyword arguments to from_orm

@hauh is correct, if we're to support this, we would need to modify `_decompose_class` to try kwargs on get before `getattr`. Please update.

Allow for passing keyword arguments to from_orm

please update.

Allow for passing keyword arguments to from_orm

The docs build is failing because #4339 was merged. It'll be failing locally and the error message explains how to fix it, so should be easy to fix. Please update.

Allow for passing keyword arguments to from_orm

Thanks so much @Bobronium for looking into this. I wonder if we should delay this feature to V2? @Bobronium @dosisod @PrettyWood @hramezani what do you think?

Allow for passing keyword arguments to from_orm

The best option long term is https://github.com/pydantic/pydantic-core/issues/223, I think that there's quite an elegant solution in rust and we don't have to worry about breaking changes. My worry is that...

Allow for passing keyword arguments to from_orm

Thanks so much for understanding, we'll do our best to make this happen in V2.

Incorrect schema generation, conflict with python-jsonschema

If it fixed in master of is there a PR?

datetime validation is less strict than the documentation suggests

Thanks for reporting. Let's fix in V2, we should also double check documentation exactly matches logic then. Happy to accept a PR now to correct docs.

datetime validation is less strict than the documentation suggests

This is fixed in pydantic-core I believe using [speedate](https://github.com/samuelcolvin/speedate), will be released in V2. Let me know if the rules applied by `speedate` are not satisfactory.