Samuel Colvin

Results 1016 comments of Samuel Colvin

Wrap validators are implemented in pydantic-core, they'll be supported in v2.

I'll try to get to this soon. I've been working pretty hard on getting pydantic-core ready for the first released, but I'll try to get back to work on 1.10...

Looks good, but having reviewed the PR, I think this would be better deal with using suggestion 2 from the original PR: looking for a `parse_env_var` method on `Config`. @acmiyaguchi...

### Notice See [twitter :bird:](https://twitter.com/pydantic/status/1560554679473303552), I've you'd like this to be included in V1.10, please fix it and request a review **TODAY**. Or if you need this in V1.10 but...

I think your implementation in #4406 is much better, I'm going to close this and accept that PR once a few small things are tweaked. > Apologies for being last...

If it started breaking between mypy versions, I would suggest reporting it to mypy and see what they say. It seems more likely to be a bug with mypy. On...

Confirmed that is weird. Thanks for reporting. Could you try to fix it? Otherwise, I'll try to fix for V1.10, otherwise it'll definitely be fixed for V2.

Thanks for providing the workaround. I still don' think this is very intuitive. I don't think setting `Field(include=` on `users` should alter whether `id` is included. Hopefully this can be...

we're definitely not making changes like that in V1.10 since the potential impact could be very subtle and quite severe, we need to think about this whole thing again for...

LGTM, please can you update the docs including an example. Please update.