Samuel Colvin
Samuel Colvin
This should be fixed in V2. Sorry for the slow reply.
This is a fix since V1.9, so really needs to be included before we release v1.10. --- #### Notice See [twitter :bird:](https://twitter.com/pydantic/status/1560554679473303552), I've you'd like this to be included in...
Okay, I'll look. In future, best if you can say "please review" so the label changes and reviewers get assigned. I basically only look at PRs with the "ready for...
> my bad, i didn't realize i had to comment it again after making changes, i assumed clicking "re-request review" would've done it Totally understandable. We might be able to...
This is great, thanks so much.
Without reviewing the code at all, I think the idea is great and the approach is great. One note, I think I'll change how examples work a lot in V2,...
please update.
You just need to add new sections to `setup.cfg` like: https://github.com/pydantic/pydantic/blob/4fb872ef3aada7ca9e64b464af9bd5c4f3d232f2/setup.cfg#L83-L84 Please update.
I've made those changes, should be ready now. Please review.
good catch, I've replied. I'll assign back to you: please update.