Samuel Colvin

Results 1016 comments of Samuel Colvin

Thanks for the detailed request. Much of this is implemented in #3739. Also, the constraints are already implemented in pydantic-core, ready for V2, eg. see [here](https://github.com/pydantic/pydantic-core/blob/0e2446d70ff68bf05c809b209bee923d6795012d/tests/validators/test_date.py#L148-L177). The only open question...

Should work for dates, times, datetimes and durations. Can't do timezone constraints yet, probably best to manage this in python.

Formats or constraining particular components can be don't in python via validators.

No, because: 1. You can do both with validators easily 2. I don't see any point in constraining formats - the formats speedate allows are already unambiguous, why make submitting...

And adding endless options will bloat pydantic and make it harder to maintain, so we can't add everything to pydantic. V2 will allow custom types to be much simpler. With...

😂 This is not a democracy.

LGTM, @coneybeare is this complete?

great, thanks so much. In future, it's safest to use the magic comment "please review" to assign the PR to me and make sure I know the PR needs my...

PR welcome. We might also want some kind of 'missing by parent exists path'?