Samuel Colvin

Results 1016 comments of Samuel Colvin

Thanks both, that's what I have https://github.com/samuelcolvin/arq/pull/331.

This looks great, thank so much. Please add tests and some to documentation. There are lots of example of tests with new syntax in `test_forward_ref.py` please update.

@irgolic will you be able to work on this and get it ready to merge? I'd really love to add this feature.

After class init, yes it should be pretty well constant. I'm theory it could change after instantiation because of extra, but I think we can ignore that for now.

Are you using the same version of libraries? You might want to merge with master to get the latest versions. Also please use the "fix #xxx" syntax in the pr...

> Hmm, I seem to still be doing something wrong with the changefile. > > EDIT: Seems like it doesn't support link syntax, only numbers. Makes sense, it's a [simple...

Luckily @Bobronium already thought about that, should be fixed in #4384, let me know if that's okay.

Will probably have to wait for V2 for a fix.

I'll get to this soon. FWIW, on @maestro-1's review: I think commenting like this is absolutely great, it's true that (in theory) you can have "too many comments", but that's...