Samuel Colvin comments

Results 1016 comments of


                                            Samuel Colvin

Generate proper JSON Schema for nullable properties

deferring this until v2.

Regression: Cannot create abstract subclass of SecretStr when abc.ABC goes first

Thanks for reporting. Seems pretty niche, do you think we need to make any changes in pydantic it just update the docs?

Regression: Cannot create abstract subclass of SecretStr when abc.ABC goes first

Totally agree. We should review prior to V2 and make sure all pydantic types exhibit the same behaviour.

The combination of a constrained type and a Generic Model raise keyerror

We'll see if we can support this in V2, no guarantees though.

validator with pre and always set to True not called when no value and no default are provided

I agree it doesn't make much sense. This will be fixed in v2.

Discriminated union does not work with aliased literal field

Yes, it's fixed in pydantic-core and will be fixed in V2.

`pydantic.Json` should enforce that dict keys may only be of type `str`

I'm not sure `x: Json[Dict[int, int]]` should be invalid actually. You may agree or disagree with pydantic's enthusiasm for coercion over validation (e.g. if you have an `int` field, `"1"`...

`pydantic.Json` should enforce that dict keys may only be of type `str`

I acknowledge the problem, we'll need to find a fix in V2.

Error with `BaseSettings` from a `.env` when trying to load a dictionary in a nested sub-model.

> Thanks @hramezani Do you have an estimated release date for V2? https://pydantic-docs.helpmanual.io/blog/pydantic-v2/#plan-timeframe

add support for selectinload relationship loading technique when orm_mode is enabled

We don't have any special support for sqlalchemy. How is pydantic supposed to know it shouldn't loo at that attribute? This there's a generic way to say "this attitude is...