Use function's keep_results configuration when storing failed jobs results
Taking a stab at using a function's (or cron job's) configuration for keeping the job results when the job fails.
I don't think this is a complete solution yet. There are a few cases where the job results are written to redis using the Worker's configuration because we can't get the Function in order to use it's config.
But maybe this is a situation where it's good enough to improve the situation for the most common situation?
Addresses #417 Relates to #416
Codecov Report
Merging #433 (a06ea04) into main (ab2dda2) will decrease coverage by
0.37%. The diff coverage is73.33%.
Additional details and impacted files
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 98.40% 98.03% -0.37%
==========================================
Files 11 11
Lines 1063 1071 +8
Branches 200 205 +5
==========================================
+ Hits 1046 1050 +4
- Misses 8 10 +2
- Partials 9 11 +2
| Files | Coverage Δ | |
|---|---|---|
| arq/worker.py | 97.80% <73.33%> (-0.78%) |
:arrow_down: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ab2dda2...a06ea04. Read the comment docs.
Agree, I think this looks good. 😊
Thanks for looking at this one! Any chance this can enter the v0.26.0b1 release? :)