arq icon indicating copy to clipboard operation
arq copied to clipboard

Update mypy

Open phy1729 opened this issue 1 year ago • 1 comments

Mypy changed the default for the implicit_optional setting, so I included that in this PR as well. Error codes are shown by default now and the ollow_imports = 'silent' setting is no longer required for mypy to pass.

phy1729 avatar May 26 '23 23:05 phy1729

Codecov Report

Merging #403 (9799c7c) into main (9109c2e) will decrease coverage by 0.20%. The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   98.66%   98.47%   -0.20%     
==========================================
  Files          11       11              
  Lines        1052     1052              
  Branches      199      199              
==========================================
- Hits         1038     1036       -2     
- Misses          6        7       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
arq/connections.py 95.20% <ø> (ø)
arq/jobs.py 98.15% <ø> (ø)
arq/worker.py 99.16% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9109c2e...9799c7c. Read the comment docs.

codecov[bot] avatar May 26 '23 23:05 codecov[bot]

Thanks so much for the contribution, this is replaced by https://github.com/samuelcolvin/arq/pull/439 where I've fixed lots of related things.

samuelcolvin avatar Apr 01 '24 11:04 samuelcolvin