arq
arq copied to clipboard
deps: Upgrade redis stubs
Quick clean-up PR. Noticed there were a lot of Redis-pipeline mypy
errors that shouldn't occur with the latest version of types-redis.
Not 100% sure if Pipeline[bytes]
is the appropriate annotation here, so please let me know if not. Also, if you have a better suggestion for how to fix types inference for the pipeline variables, that's of course very welcome; the manual definitions are not ideal.
Codecov Report
Merging #399 (41dd920) into main (9109c2e) will not change coverage. The diff coverage is
100.00%
.
Additional details and impacted files
@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 11 11
Lines 1052 1052
Branches 199 199
=======================================
Hits 1038 1038
Misses 6 6
Partials 8 8
Impacted Files | Coverage Δ | |
---|---|---|
arq/connections.py | 95.20% <100.00%> (ø) |
|
arq/jobs.py | 98.15% <100.00%> (ø) |
|
arq/worker.py | 99.16% <100.00%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9109c2e...41dd920. Read the comment docs.
The pipeline types aren't being inferred correctly due to mypy. If the latest mypy version is used, those hints are no longer needed.
I've submitted #403 to update mypy, but it'll conflict with your PR. If this PR is merged first I can rebase and add a commit to remove the hints.
Thanks so much for the contribution, this is replaced by https://github.com/samuelcolvin/arq/pull/439 where I've fixed lots of related things.