arq icon indicating copy to clipboard operation
arq copied to clipboard

Allow infinite retry

Open vvmruder opened this issue 1 year ago • 1 comments

In some contexts (cluster) it is useful to allow infinite retries float('inf'). Especially in clusters redis might be not available for some time but we don't want the worker to crash on that. Instead it just should wait until redis comes available again.

float('inf') always compare greater than any float or int. So it should be safe to use. But str(float('inf')) translates to 'inf' and that's why this change is necessary.

vvmruder avatar May 10 '23 09:05 vvmruder

Codecov Report

Merging #396 (ddc8e77) into main (e0cd916) will not change coverage. The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          11       11           
  Lines        1052     1052           
  Branches      199      199           
=======================================
  Hits         1038     1038           
  Misses          6        6           
  Partials        8        8           
Impacted Files Coverage Δ
arq/connections.py 95.20% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0cd916...ddc8e77. Read the comment docs.

codecov[bot] avatar May 10 '23 09:05 codecov[bot]

thanks so much.

samuelcolvin avatar Apr 01 '24 14:04 samuelcolvin

v0.26.0b1 is released, please try it, I'll release v0.26 at the end of the week, see #441.

samuelcolvin avatar Apr 01 '24 18:04 samuelcolvin