aioaws icon indicating copy to clipboard operation
aioaws copied to clipboard

Support `ACL` flag

Open odiseo0 opened this issue 2 years ago • 5 comments

I also changed the name of BaseConfigProtocol to ConfigProtocol

odiseo0 avatar Jan 13 '23 19:01 odiseo0

Codecov Report

Merging #40 (89f120c) into main (332855f) will decrease coverage by 0.60%. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   96.64%   96.03%   -0.61%     
==========================================
  Files          10       10              
  Lines         626      631       +5     
  Branches      102      103       +1     
==========================================
+ Hits          605      606       +1     
- Misses         15       17       +2     
- Partials        6        8       +2     
Impacted Files Coverage Δ
aioaws/_types.py 100.00% <100.00%> (ø)
aioaws/_utils.py 88.88% <100.00%> (ø)
aioaws/core.py 98.34% <100.00%> (-1.66%) :arrow_down:
aioaws/s3.py 97.69% <100.00%> (-1.51%) :arrow_down:
aioaws/ses.py 95.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 332855f...89f120c. Read the comment docs.

codecov[bot] avatar Jan 13 '23 19:01 codecov[bot]

Will add some thanks for sure.

Do you mean set the acl to None and only use it in case if set? Okay, no problem

odiseo0 avatar Jan 13 '23 19:01 odiseo0

Do you mean set the acl to None and only use it in case if set? Okay, no problem

Exactly

samuelcolvin avatar Jan 13 '23 19:01 samuelcolvin

Will do, thanks so much for the feedback

odiseo0 avatar Jan 13 '23 19:01 odiseo0

This PR it's ready for review, I've been using my fork and the ACL flag it's working correctly. Thanks for this small library

odiseo0 avatar Jan 31 '23 20:01 odiseo0