nixpkgs-upkeep icon indicating copy to clipboard operation
nixpkgs-upkeep copied to clipboard

Don't create multiple issues

Open fabaff opened this issue 2 years ago • 4 comments

For the same failure the script creates new issues with every run it seems, e. g., like #169873.

If there is already an open issue then the script should pass that step or update the already present issue.

fabaff avatar Apr 23 '22 10:04 fabaff

Related https://github.com/samuela/nixpkgs-upkeep/issues/17#issuecomment-1105863730

SuperSandro2000 avatar Apr 24 '22 22:04 SuperSandro2000

Hey guys, sorry for the duplicate issues! I'm actively trying to figure out the best way to dedup issues. The current solution is to check for existing issues (open or closed) that either

  • contain the same last 10 log lines, timing info removed, or
  • have the same drv hash

But unfortunately every time I update the deduplication hashes, it then causes pre-existing issues to not be recognized. So although I think the current system does a decent job, it did take a decent amount of trial and error to get here. I'm really sorry about the spam! I try to do my best to triage any issues as they get generated.

samuela avatar Apr 25 '22 03:04 samuela

Also, if you have any other ideas to improve the issue dedup'ing hashes, I'd be genuinely curious to hear! I'm open to any improvements to the system.

samuela avatar Apr 25 '22 05:04 samuela

I would suggest to use an extra repository right now. Then you can fidel with the code, test things and try to get the early bugs squashed out. If everything is battle tested and working to your likings it can be put live on nixpkgs. This way we can keep the disruption low and don't ping people unnecessarily.

SuperSandro2000 avatar Apr 25 '22 14:04 SuperSandro2000