go-zookeeper icon indicating copy to clipboard operation
go-zookeeper copied to clipboard

idempotent Close; queueRequest guards against deadlocks on closed connections

Open jdef opened this issue 7 years ago • 7 comments

  • fixes #148

jdef avatar Jan 13 '18 22:01 jdef

Coverage Status

Coverage increased (+0.3%) to 43.353% when pulling cc6f56c50b37dfb404a173c64206d9d5290df2a4 on jdef:jdef/zkclose into 471cd4e61d7a78ece1791fa5faa0345dc8c7d5a5 on samuel:master.

coveralls avatar Jan 13 '18 22:01 coveralls

Coverage Status

Coverage increased (+37.6%) to 80.588% when pulling f1083c7e8fce527a84910dace1d0b26ec11fc485 on jdef:jdef/zkclose into 471cd4e61d7a78ece1791fa5faa0345dc8c7d5a5 on samuel:master.

coveralls avatar Jan 18 '18 18:01 coveralls

Coverage Status

Coverage increased (+0.2%) to 80.266% when pulling dd6d4dd6d0abcda16105e0b81c25b9cfdfe8f635 on jdef:jdef/zkclose into c4fab1ac1bec58281ad0667dc3f0907a9476ac47 on samuel:master.

coveralls avatar Jan 18 '18 18:01 coveralls

rebased to master

jdef avatar Feb 09 '18 00:02 jdef

@samuel PTAL

jdef avatar Feb 09 '18 01:02 jdef

@samuel We're currently experiencing the #148 panics in our projects and would love to see this merged!

atavakoli avatar Feb 27 '19 23:02 atavakoli

Any reason this seems to have stalled? Happy to take it over if that is ok?

grantstephens avatar Jun 04 '20 08:06 grantstephens