go-thrift icon indicating copy to clipboard operation
go-thrift copied to clipboard

generate Generate methods for enums (compatible with testing/quick)

Open nuance opened this issue 10 years ago • 5 comments

More testing/quick support

nuance avatar Sep 23 '15 17:09 nuance

As this seems only useful for testing could be put behind a flag (defaulted to false). Does that seem reasonable?

samuel avatar Sep 25 '15 21:09 samuel

Part of my worry is that it makes generated code depend on reflect

samuel avatar Sep 25 '15 21:09 samuel

Yup, that sounds totally reasonable. I'll update the diff.

On Sep 25, 2015, at 2:27 PM, Samuel Stauffer [email protected] wrote:

Part of my worry is that it makes generated code depend on reflect

— Reply to this email directly or view it on GitHub.

nuance avatar Sep 25 '15 23:09 nuance

Would there be any benefit to generating these functions in a separate companion file (e.g. testing.go) like we do for rpc.go?

jparise avatar Sep 26 '15 02:09 jparise

Oops, forgot to actually push my changes

nuance avatar Oct 07 '15 22:10 nuance