htsjdk icon indicating copy to clipboard operation
htsjdk copied to clipboard

Add support for the TP (topology) tag in the sequence dictionary

Open nh13 opened this issue 5 years ago • 5 comments

See https://github.com/samtools/hts-specs/pull/405

nh13 avatar May 02 '19 22:05 nh13

Holding off until samtools/hts-specs#405 is merged.

cmnbroad avatar May 06 '19 18:05 cmnbroad

From the commit message:

as well as if the start (or mate start) is off the end.

Um… not sure anyone has made a case for allowing this?

jmarshall avatar May 07 '19 09:05 jmarshall

@jmarshall

Um… not sure anyone has made a case for allowing this?

That's definitely my mistake. I think what I want is to say that it's ok for the mate's start to be past the end of the reference as long as the current start is not. So we can have a template span the origin, but not have a template that goes past it. If that makes sense, I'll fix the implementation.

nh13 avatar May 07 '19 16:05 nh13

I suggest the non-controversial parts be extracted into a separate PR.

yfarjoun avatar Aug 12 '19 18:08 yfarjoun

note that testLongReferenceQuery is failing in Travis.

yfarjoun avatar Sep 23 '19 14:09 yfarjoun