KiteJSONValidator icon indicating copy to clipboard operation
KiteJSONValidator copied to clipboard

Published 20 hours ago • verified publisher icon samskiter

Added error propagation and project fixes

Open werner77 opened this issue 6 years ago • 3 comments

  • Added error propagation to be able to inspect the reason of validation failure
  • Fixed schema reference resolving: delegate is now called
  • Updated project to recommended settings
  • Added MacOSX as platform to pod spec
  • Added Nullability annotations
  • Fixed travis config

werner77 avatar Mar 07 '18 16:03 werner77

Hey thanks for the contribution - this looks great!

Can you maybe decompose these changes a little to make them easier to review.

Looks like you've solved https://github.com/samskiter/KiteJSONValidator/issues/12

And https://github.com/samskiter/KiteJSONValidator/issues/2

As well as update the project more generally...

Perhaps there's 3 (or more) Pull requests here?

Thanks again!

Sam

samskiter avatar Mar 07 '18 17:03 samskiter

Hi Sam, It's a bit hard to split off the changes after the fact, I could help with the review though?

werner77 avatar Mar 08 '18 08:03 werner77

Sure, I first want to understand the project changes made if possible. E.g. I'm not sure why the scheme changed... Are you sure they couldn't easily be pulled into their own PR?

samskiter avatar Mar 08 '18 08:03 samskiter