Maestral is uploading the "selective sync conflict" folders back into Dropbox

[raffaem]

Describe the bug After #446 I am rebuilding the index.

Maestral is now uploading the "selective sync conflict" folders back to Dropbox.

To Reproduce Have a "selective sync conflict" folder and rebuild the index

Expected behaviour It should not upload it to Dropbox since the folder is already on Dropbox (I just forgot to select it in the preferences)

[raffaem]

I have removed ~/.local/share/maestral and reinstalled maestral.

I re-selected the ex Dropbox folder, chose to merge, and made absolutely sure to select the exact same folders there are already there :)

Maestral is now like "2021-09-02 00:47:15 sync DEBUG: Equal content hashes for "[...]": no conflict" 😎

[samschott]

Maestral is now uploading the "selective sync conflict" folders back to Dropbox.

That is expected behaviour currently. It assumes that the local folder is different from the folder on Dropbox servers, since you excluded the remote folder with selective sync, and that any similarities in name are only coincidental. The "selective sync conflicts" are therefore uploaded.

[raffaem]

Maestral is now uploading the "selective sync conflict" folders back to Dropbox.

That is expected behaviour currently. It assumes that the local folder is different from the folder on Dropbox servers, since you excluded the remote folder with selective sync, and that any similarities in name are only coincidental. The "selective sync conflicts" are therefore uploaded.

Can we have that, if you select "Merge", it will auto-select the folders in local that are also in remote in the following screen?

So you don't forget anything :)

[samschott]

Can we have that, if you select "Merge", it will auto-select the folders in local that are also in remote in the following screen?

This would certainly be convenient, the difficulty would likely be in the implementation.

At the moment, all files and folders are selected for syncing by default, which is really easy to do. If we would automatically select folders which are present locally and uncheck folders which are only present remotely in the selective sync page of the setup dialog, this would require getting a full list of all remote folders (and files) first. At the moment, folders are loaded on-demand, when they are expanded in the GUI. Loading all remote items in advance could potentially be very slow, especially for users with > 100,000 items in their Dropbox.

A potential way around this would be to perform the check for top-level folders only (which are more commonly excluded from syncing). Do you think this would already be useful by itself? Otherwise, I'll need to think about possible solutions but don't have any immediate ideas.

[raffaem]

Dunno, I also uncheck top-level folders that must stay on remote and not sync on local. But maybe someone else unchecks subfolders or sub-sub-folders.

Maybe, if it's not possible to fetch the all the remote folder list, a warning that tells the user to select all the folders he already has in local.

Or an option to choose between fetching all the remote folders and select automatically, or let the user select them (with a warning that fetching all the remote list could take a long time)