thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Fix for "Bug: FieldFunc selectionSet argument is always nil"

Open Dorokhov opened this issue 6 years ago • 3 comments

Fix #200 @twalwyn @kvap

Dorokhov avatar Nov 20 '18 11:11 Dorokhov

Pull Request Test Coverage Report for Build 1329

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 62.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
graphql/schemabuilder/function.go 2 3 66.67%
graphql/schemabuilder/pagination.go 0 1 0.0%
<!-- Total: 2 4
Files with Coverage Reduction New Missed Lines %
graphql/schemabuilder/input.go 4 61.76%
<!-- Total: 4
Totals Coverage Status
Change from base Build 1326: -0.05%
Covered Lines: 3592
Relevant Lines: 5724

💛 - Coveralls

coveralls avatar Nov 20 '18 11:11 coveralls

Would be nice to have a unit test for that.

kvap avatar Nov 20 '18 11:11 kvap

@Dorokhov @kvap Would be great to see this crossing the finish line

uripre avatar Mar 18 '21 12:03 uripre