create-vite-plugin-web-extension icon indicating copy to clipboard operation
create-vite-plugin-web-extension copied to clipboard

chore: bump @types/chrome in templates to 0.0.263

Open keyding opened this issue 1 year ago • 2 comments

Prior to version 0.0.254, the type of ManifestBass["author"] in @types/chrome was as follows:

// ...

export interface ManifestBase {
    // Required
    manifest_version: number;
    name: string;
    version: string;

    // Recommended
    default_locale?: string | undefined;
    description?: string | undefined;
    icons?: ManifestIcons | undefined;

    // Optional
    author?: string | undefined

    // ...
}

After version 0.0.254(As of now, the latest version is 0.0.263), the type of ManifestBass["author"] in @types/chrome is as follows:

//  ...

export interface ManifestBase {
    // Required
    manifest_version: number;
    name: string;
    version: string;

    // Recommended
    default_locale?: string | undefined;
    description?: string | undefined;
    icons?: ManifestIcons | undefined;

    // Optional
    author?: {
        email: string;
    } | undefine

    // ...
}

keyding avatar Mar 31 '24 03:03 keyding

Appreciate the PR! Rather than add [email protected], can you just remove the author fields everywhere? It's optional so there's not really any reason to set it in the templates at all really.

samrum avatar Apr 04 '24 04:04 samrum

Appreciate the PR! Rather than add [email protected], can you just remove the author fields everywhere? It's optional so there's not really any reason to set it in the templates at all really.

Thanks for the recognition! I think you are right and I have made the changes.

keyding avatar Apr 04 '24 14:04 keyding