Sam Ritchie
Sam Ritchie
You will already have multiple `TableContext`s with their own DynamoDB client, I’m wondering if it’s neater/more consistent/more obvious to just have an extra non-generic `MultiTableContext` that implements the Transact (&...
We could certainly add a convenience `TableContext.MultiTableContext` getter to minimise the ceremony for users that want to do ad hoc multi table transactions, but creating an additional context would not...
I think `TransactionBuilder` is definitely better than methods on the context. My main concern here is the rest of the public API is method-based rather than modules & functions -...
Thanks @purkhusid for your efforts here. I’m happy with this design, just a bit unsure about naming (not wanting to start an endless 'naming things' discussion but would like to...
@purkhusid yes - that looks good.
Yes, that seems okay, we don’t have particularly rapid uptake of the new version. Re: metricsCollector I’d like to see this go eventually & expose the same data via OpenTelemetry...
There’s AWS SDK OpenTelemetry instrumentation in beta, but I’ve had a look and it’s not very useful; one of the perils of a codegen SDK. Having something implemented here would...
I think this is good in principle, but just unsure what the behaviour with key attributes should be - if the SDK throws an exception or (more likely but less...
Unsure if this is already common library usage but duplicating attributes in a record via `CustomName` seems odd (especially key attributes) - aside from anything else I don’t know what...