sack icon indicating copy to clipboard operation
sack copied to clipboard

Support patterns containing spaces

Open elzibubble opened this issue 10 years ago • 7 comments

There's special support for "$@". If $@ => "a b c", then "$@" => "a" "b" "c".

elzibubble avatar Jun 19 '15 16:06 elzibubble

Fixes issue #21

elzibubble avatar Jun 19 '15 16:06 elzibubble

Apologies for neglecting pull requests for so long. I just merged several, and this one now has conflicts. Please update if you are interested in having it in, or I'll take a look at it hopefully sometime next week.

sampson-chen avatar Aug 25 '15 06:08 sampson-chen

Hey, how to see these merge conflicts and resolve them? Would be great if sack could search for patterns with spaces.

Konfekt avatar Jan 19 '16 11:01 Konfekt

After all, the pull request does not look to complicated. Should I reoffer it?

Konfekt avatar Jan 19 '16 11:01 Konfekt

Hi Konfekt, please feel free. I spent all of 20 seconds on it mind, it may not be super robust.

On Tue, 19 Jan 2016 at 11:42 Konfekt [email protected] wrote:

After all, the pull request does not look to complicated. Should I reoffer it?

— Reply to this email directly or view it on GitHub https://github.com/sampson-chen/sack/pull/22#issuecomment-172825947.

elzibubble avatar Jan 20 '16 11:01 elzibubble

Yeah, actually there's now https://github.com/sampson-chen/sack/pull/31 but it doesn't fix much. For the moment switched to https://raw.githubusercontent.com/majutsushi/etc/master/zsh/sack

Konfekt avatar Jan 20 '16 12:01 Konfekt

Yeah, actually there's now https://github.com/sampson-chen/sack/pull/31 but it doesn't fix much. For the moment switched to https://raw.githubusercontent.com/majutsushi/etc/master/zsh/sack

Konfekt avatar Jan 20 '16 12:01 Konfekt