plyr
plyr copied to clipboard
sampotts
Double Clicking in Youtube Player enters Youtube Fullscreen instead of Plyr
Expected behaviour
When i doubleclick a running youtube video it behaves like when pressing the fullscreen button.
I should still see the progress bar of plyr and be able to use the shortcuts.
Actual behaviour
When i doubleclick a running youtube video i get a fullscreen of the video where i cant see the plyr progress bar or use plyr's shortcuts. It seems like its Youtubes Fullsreen instead of Plyr's Full Screen.
Steps to reproduce
- Visit https://plyr.io/#youtube
- Play the video
- Double Click in the middle of the video
- No Progress Bar
Same issue on my live website using latest version of Plyr, On localhost with an older version of Plyr this does not happen and double clicking exits fullscreen rather than loading into youtube.
This is present in the newest version. @sampotts
he prolly wont care because vidstack is the new thing and this will get deprecated as soon as its done.
Sorry, I'll see if there's an easy fix for this.
he prolly wont care because vidstack is the new thing and this will get deprecated as soon as its done.
I've not had a lot of time to work on either Plyr or Vidstack recently unfortunately. I won't let Plyr die though, that's for sure. Plenty of folks will still want to use it so if the need is there, I'll try my best to keep it maintained.
The problem here is that:
- We need to enable pointer events to hit the underlying YouTube iframe so that it's possible to interact with the now impossible-to-hide Share, Watch later, More videos, etc, but inversely,
- We don't want double click to travel down to the frame.
Since using the custom controls with YouTube is already a policy violation (hence the customControls option), a possible solution might be to show the poster image when the video is paused, it's just not a great experience. Either that or a blank screen. It's a shame we can't capture the current frame of the video somehow. I'll keep thinking about it.
