Sam Potts comments

Results 108 comments of


                                            Sam Potts

Request : force fullscreen in landscape on mobile devices

Good idea. Will look into it... 👍

Request : force fullscreen in landscape on mobile devices

@ammein Get a pull request in 👍

Request : force fullscreen in landscape on mobile devices

Looks like there's no support in Safari: https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock But we can always add this in...

Request : force fullscreen in landscape on mobile devices

No pull requests yet?!

Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause()

This seems to be a Chrome issue by the looks of things: https://bugs.chromium.org/p/chromium/issues/detail?id=593273

Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause()

Closing this and waiting on a Chrome fix

Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause()

No update but it can be safely ignored. v3 will return a `Promise` for calls to `.play()` and will be in beta very soon.

Thank you for this library

Thanks mate! It’s good to see this. I’ve not spent much time on this package for a while but regardless, thanks!

Potential issue with iOS 11.3+

Apologies. I’ll look at this ASAP. Sam > On 29 May 2018, at 5:56 pm, Sam Chung wrote: > > I am seeing this as well. I forked it and...

Potential issue with iOS 11.3+

You could omit the need for the reload and do it all dynamically using a MutationObserver. I'll try and take a look asap. If anyone comes up with a PR...