WhiteOctoberSwiftMailerDBBundle icon indicating copy to clipboard operation
WhiteOctoberSwiftMailerDBBundle copied to clipboard

Support for SwiftMailerBundle v3.x

Open malas opened this issue 6 years ago • 5 comments

Hey everyone,

are there any plans to support the newer version of SwiftMailerBundle? There are a lot of bug fixes in the SwiftMailer new version which are not included in the SwiftMailerBundle v2.x

malas avatar Oct 26 '17 09:10 malas

Hi @malas, thanks for raising this.

Unfortunately, the amount of development time we have available for this bundle is very limited at present, so we're unlikely to get time for this upgrade.

If someone in the community has time to create a Pull Request for this then that would be greatly appreciated, of course!

What I have done is create a simple untested branch, swiftmailerbundle-v3, which uses v3 of the SwiftMailerBundle. This means that you can include it in your composer.json like this:

"require": {
    "whiteoctober/swiftmailerdbbundle": "dev-swiftmailerbundle-v3"
}

(http://vvv.tobiassjosten.net/php/have-composer-use-development-branches/)

Now, this isn't intended for production use, of course. But it will hopefully make the job of testing this bundle with SwiftMailerBundle v3 easier for anyone who has time to do that (do you?) making it more likely that someone will also have time to create a PR with any necessary fixes.

Sorry not to be able to do more at this point. Thanks again for raising this.

sampart avatar Nov 08 '17 17:11 sampart

thanks for the response. i will see what our team can do to test this and possible make a PR. Will post updates here.

malas avatar Nov 08 '17 17:11 malas

That's brilliant. Thank you very much indeed!

sampart avatar Nov 09 '17 09:11 sampart

@malas Any updates? It does not seem to work out of the box for me.

torchello avatar Apr 12 '18 14:04 torchello

@torchello we changed our email infrastructure so this is no longer an issue for us. Feel free to make the PR yourself.

malas avatar Apr 12 '18 14:04 malas