Sambit Panda comments

Results 47 comments of


                                            Sambit Panda

Index error in MGCX

Sorry for the late response, this just got on my radar right now. I'll take a look into this

Feature Request: Add Support for Parallel Processing

I think this is a great idea > Parallel computation of test statistics: This could involve using multiprocessing or joblib to compute test statistics in parallel, which could significantly speed...

Optimizations for scikit-tree to improve multi-core performance

![image (1)](https://github.com/neurodata/scikit-tree/assets/36676569/8e900e0b-c956-4582-8693-86cab085be55) ![image](https://github.com/neurodata/scikit-tree/assets/36676569/4cdca77f-8d6a-457e-9cc3-d84dd51b584c)

Optimizations for scikit-tree to improve multi-core performance

> ![image (1)](https://private-user-images.githubusercontent.com/36676569/312216093-8e900e0b-c956-4582-8693-86cab085be55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAyNzI4NzEsIm5iZiI6MTcxMDI3MjU3MSwicGF0aCI6Ii8zNjY3NjU2OS8zMTIyMTYwOTMtOGU5MDBlMGItYzk1Ni00NTgyLTg2OTMtODZjYWIwODViZTU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzEyVDE5NDI1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI1YTQyNDU0ZjRhYjhmNGQ2MmRiZDAwMWQ5ZjU3MjRkODM4ZDM2N2QzNTA4Y2JhNDMwYjU0OGVkMjMzYTg4Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.HjgNHZEFPJEN39vHU7Vhd_8GFneYAogJyZCajXDMBXs) CoMIGHT before changes in #242 > ![image](https://private-user-images.githubusercontent.com/36676569/312216099-4cdca77f-8d6a-457e-9cc3-d84dd51b584c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAyNzI4NzEsIm5iZiI6MTcxMDI3MjU3MSwicGF0aCI6Ii8zNjY3NjU2OS8zMTIyMTYwOTktNGNkY2E3N2YtOGQ2YS00NTdlLTljYzMtZDg0ZGQ1MWI1ODRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzEyVDE5NDI1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcxOTA3MTJjM2Y0YzhjOWI4NzcxOTQzZDk5NWY3NTRkODY0NWM3ODI2OTcyMmJlNmMxMmNhNTJiMDVjNmU3NmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ilF9yenwTIs1l1BC1kRbu1rP3r2YKrzxU7WregmY_LM) CoMIGHT after changes in #242

Optimizations for scikit-tree to improve multi-core performance

it is not

Optimizations for scikit-tree to improve multi-core performance

wooot!!

make this a pip package that is sklearn API compliant

At the very least, all functions should inherit from the [base classes](https://scikit-learn.org/stable/modules/classes.html). A more comprehensive tutorial can be found [here](https://scikit-learn.org/stable/developers/develop.html). The tl;dr for the last guide is that it needs...