Sambit Panda
Sambit Panda
@ebridge2 any thoughts?
None of the functions that you added have been Cythonized. All the functions added use ``def`` which is calling pure Python
> Then I don’t really understand why cythonizing is necessary if pure python works. Pure python is slow. With large datasets, it will long time to run.
https://github.com/kfangster/scipy
@darsh-patel This isn't enough for an NDD project. Didn't we talk last semester about cleaning up the goodness of fit module? And adding more tests?
Is this only for Friedman Rafsky, or other tests in hyppo?
Thank you for your issue, will investigate and see if I can find the bug in the code.
I found the bug, seems to be an array broadcasting issue. Should work now. I'll patch it and send in an updated version soon
tests against sinusodial sims, general nonlinear sims, etc.
Hello, thank you for looking into this. If you look at the unit tests in the package, currently it only verifies if the test statistic and p-value are the same...