SimpleAuth icon indicating copy to clipboard operation
SimpleAuth copied to clipboard

[BUG] [Fabric] Players seem to be teleported after entering a wrong password and joining the server again

Open IotaBread opened this issue 3 years ago • 1 comments

Mod Loader

  • [x] Fabric
  • [ ] Forge

Versions

  • SimpleAuth 1.6.1
  • Fabric API 0.23.0+build.410

Describe the bug For some reason, players are teleported to a different position from the one that they logged out from (probably a position stored on the database). As far as I know, this has only happened after updating the mod to 1.6.

To Reproduce Steps to reproduce the behaviour: (Probably you won't be able to reproduce it like this, but this is how the player that reported the issue to me reproduced it)

  1. Enter a server, move around a bit and leave it until the session expires, repeat.
  2. Enter the server and try logging with a wrong password.
  3. Enter the server again.
  4. See that the position you left is different from the position you are on.

Expected behaviour The player should not be teleported to another position after entering a wrong password

Additional context Note that we moved from SimpleAuth 1.5, so that could be related to the issue. We have maxLoginTries set to 1 on the config. Here is a log of the situation

[00:46:06] [Server thread/INFO]: FrancixX[/] logged in with entity id 850303 at (1137.2919169802237, 58.0, 2390.6704544124805)
[00:46:06] [Server thread/INFO]: FrancixX joined the game
[00:46:11] [Server thread/INFO]: FrancixX lost connection: §4Wrong password!
[00:46:11] [Server thread/INFO]: FrancixX left the game
[00:46:11] [Server thread/WARN]: handleDisconnection() called twice
[00:46:15] [Server thread/INFO]: FrancixX[/] logged in with entity id 850602 at (1132.1919952388205, 63.5, 2392.721017794696)
[00:46:15] [Server thread/INFO]: FrancixX joined the game

IotaBread avatar Oct 21 '20 23:10 IotaBread