With this configuration, item data is being cleared and we DONT want that

[wh0oo]

We have disabled all of the settings that would be clearing NBT data, but it still is.

{
  "main": {
    "_comment_checkInventoryActions": "// Prevents hitting/chatting with open GUI",
    "checkInventoryActions": false
  },
  "items": {
    "survival": {
      "_comment_legalise": "// Whether to enable 'legalising' survival items.",
      "_comment_bannedSurvivalItems": "// Which items should be cleared when clicked in survival inventory",
      "bannedItems": [],
      "checkEnchants": false,
      "checkPotionLevels": false,
      "checkItemCount": false
    },
    "creative": {
      "_comment_whitelistedNBT": "// Which NBT shouldn't be cleared",
      "whitelistedNBT": [
        "EntityTag",
        "Enchantments",
        "StoredEnchantments",
        "BlockEntityTag",
        "Damage",
        "Potion",
        "display"
      ],
      "_comment_removeCreativeNBTTags": "// Disallow all NBT tags in creative which aren't in whitelist section.",
      "removeCreativeNBTTags": false,
      "checkEnchants": false,
      "checkPotionLevels": false,
      "checkItemCount": false
    }
  },
  "combat": {
    "_comment": "// Combat checks settings.",
    "preventWallHit": false,
    "checkHitDistance": false,
    "checkHitAngle": false
  },
  "packet": {
    "_comment": "// Patches some outgoing server packets",
    "removeTeleportData": false,
    "removeHealthTags": false,
    "removeEquipmentTags": false,
    "checkPortalHack": false,
    "patchSoundExploits": true,
    "removeDroppedItemInfo": false,
    "patchItemKickExploit": true
  },
  "movement": {
    "_comment": "// Movement checks settings",
    "yesFall": false
  },
  "duplication": {
    "_comment": "// Duplication fixes",
    "_comment_patchSaveLimit1": "// Whether to prevent throwing an error when saving large string data.",
    "_comment_patchSaveLimit2": "// This is done by ignoring data after DataOutputStream limit.",
    "_comment_patchSaveLimit3": "// Written books can reach that point with hacked clients.",
    "patchSaveLimit": true,
    "_comment_patchGravityBlock": "// Whether to disable gravity block duping.",
    "patchGravityBlock": true,
    "_comment_patchDeathDuplication1": "// Checks if player is connected before applying damage.",
    "_comment_patchDeathDuplication2": "// Prevents duplicating inventory if player dies after disconnect.",
    "patchDeathDuplication": true
  }
}

[wh0oo]

I should add that what is being cleared is all the NBT data for armor, weapons, tools, and whatnot.

I do believe that the following should cover that,

"removeEquipmentTags": false,

but its not.

[cherie535]

On second look, that is actually not the proper toggle. And I dont see any that would cause what we are seeing.

[samolego]

If it is just a sync issue (not real clearing), disable patchItemKickExploit (see #39). Otherwise, it's a new bug. Thanks for report.

[cherie535]

I dont know how to tell if its a sync issue or not. The tags, enchantements and whatnot dont ever show up though, if thats what you are suggesting? And disabling that isnt an option, thats what what we wanted it for in the first place.

[samolego]

You can tell it's a sync issue if it reverts after clicking on item. If it goes back to normal, it's a sync issue, otherwise sounds like a new bug.

[cherie535]

OK, I have just checked for that, and no, they dont reappear.

[cherie535]

awesome, I re-downloaded the mod to test if this was a sync issue and it has stripped all the enchantments and nbt tags from everything that was in my inventory when I was running the mod. The tags didnt return when I unloaded the mod. I think that's covered in another ticket. I am very happy it was just me that was affected.

[githubbingitup]

If it is just a sync issue (not real clearing), disable patchItemKickExploit (see #39). Otherwise, it's a new bug. Thanks for report.

I had the same problem. Mine was just a client bug where items would revert after clicking on them. I tried disabling all the settings in the config file and it didn't fix it. Disabling the packet ones would straight up cause server crashes so I ended up just having to remove Golf.

[Ampflower]

Is this by chance with Creative? #58 may provide a fix if it is indeed such.

Note, due to how it's implemented, some stuff such as shulker boxes will appear as if they're missing their inventory.