FabricTailor icon indicating copy to clipboard operation
FabricTailor copied to clipboard

[Feature] Warn about internet conection on `/skin set`

Open Apis035 opened this issue 11 months ago • 7 comments

Minecraft 1.20.4 Fabric Tailor 2.3.0

Upon entering this command with no internet connection, it will respond with:

Trying to set the skin ... Please wait. Uploading skin. Please wait. You have to provide URL, player's name or file of the skin you want.

Does work fine when having internet connection.

I'm playing on a local LAN with friends with no internet connection, using this mod to set our skins.

Apis035 avatar Mar 02 '24 08:03 Apis035

This mod doesn't change skin fetching mechanic, it still uses mojang's system. So it needs internet access.

samolego avatar Mar 02 '24 13:03 samolego

Ooh, I thought it wasn't supposed to be like that because of the respond message. It also delayed few seconds before displaying "You have to provide URL, player's name or file of the skin you want." like it is actually doing something. 🤔

Maybe change the error message to indicate that this mod doesn't work without internet connection?

Apis035 avatar Mar 03 '24 01:03 Apis035

It's doing something but fails to do it ... error mesaage is pretty generic, yeah. Probably shows some info in logs?

samolego avatar Mar 03 '24 07:03 samolego

Yeah, that would be better

Apis035 avatar Mar 04 '24 07:03 Apis035

the error still pops up even with internet connection

LegendaryMouse avatar Mar 24 '24 19:03 LegendaryMouse

image

/skin set URL classic "https://cdn.discordapp.com/attachments/1202616582841434132/1221545557164556459/123.png?ex=6612f7f4&is=660082f4&hm=a2bd6aa1dd14eea76cbc226de46dc58e6feeb5646d98f5498dac16f773cfa0b4&"

LegendaryMouse avatar Mar 24 '24 19:03 LegendaryMouse

imgur and other servers show same error

LegendaryMouse avatar Mar 24 '24 19:03 LegendaryMouse