betterdiscord-plugins icon indicating copy to clipboard operation
betterdiscord-plugins copied to clipboard

Use Discord message links in Quoter

Open bb010g opened this issue 5 years ago • 10 comments

I think this covers everything backwards-compat wise, if you care about that. All the whitespaces changes are just from yarn run gulp, so you may want to view the diff with --ignore-space-change.


This change is Reviewable

bb010g avatar Oct 01 '18 22:10 bb010g

Last time I checked this links opened as external links in browser (without plugin installed). Can desktop clients recognize them now?

samogot avatar Oct 01 '18 23:10 samogot

No, and I realized that my regex was a bit messed up, so fixing that now. This would still be an improvement on Android (where you can tell the link to open in the app and it works), and the plugin can force navigation like it did before until a better way is figured out.

bb010g avatar Oct 01 '18 23:10 bb010g

I addressed this in the server Samo. This doesn't really add much since it wouldn't work for other users on desktop which is the main feature here. Those links are opened properly if used in the markdown sections of the embed instead of as the title or author url however. So we could add an option to have an additional embed field with name Reference Link with the body of the field being the discord link.

rauenzi avatar Oct 01 '18 23:10 rauenzi

Ok, regexes are fixed and it actually jumps now with the plugin. I like the body embed idea for people who don't have this installed.

bb010g avatar Oct 01 '18 23:10 bb010g

I have that mostly implemented, but I didn't want to add such a feature until Samogot came back and we could discuss it

rauenzi avatar Oct 01 '18 23:10 rauenzi

Relevant verified bug for this behavior: https://trello.com/c/WD5FyVBu/2124-jump-urls-dont-work-if-masked

bb010g avatar Oct 02 '18 00:10 bb010g

The links seem to work on desktop now and web

ajayyy avatar Feb 01 '19 21:02 ajayyy

MERGABLE. This works perfectly

ajayyy avatar Mar 06 '19 21:03 ajayyy

Any update on this?

Lypheo avatar Sep 16 '19 11:09 Lypheo

@Lypheo it works completely fine. I run this version on my client and the links work.

ajayyy avatar Sep 18 '19 02:09 ajayyy