Sam Marks

Results 46 comments of Sam Marks

**Note for whenever I get around to this:** [this library](https://github.com/kreuzerk/dinosaur-icons/tree/master/projects/dinosaur-icons) is probably a good starting point for determining the structure of the icon library.

I would check out [this StackOverflow post](https://stackoverflow.com/questions/72088414/hookwebpackerror-emfile-too-many-open-files-when-execute-npm-run-export) on someone experiencing a similar issue with Material UI icons. It offers a different way of importing the icons as a solution. While...

These also seem related: - https://github.com/mui/material-ui/issues/35450 - https://github.com/mui/material-ui/issues/36043 Which is strange because we just overhauled our packaging to be more compatible with ESM. Happy to accept a PR if you're...

> Which is weird... I'd have thought vercel/webpack to perfected the tree shaking part I would have thought so too 😅 but it appears either we have something setup in...

The problem is if you remove the exports field, then using Iconoir inside server components in the app directory breaks 😉 Looks like we'll end up having to figure out...

@Mitsunee Do you have an example of a lib using the `exports` approach successfully where the tree-shaking is working perfectly inside Next? That would be really helpful in updating our...

@Mitsunee I noticed in an email you had a comment that had a code snippet like the following: ```json { "exports": { // ... "./*": { "types": "./dist/*.d.ts", "import": "./dist/esm/*.mjs",...

And thus we have the current state of NodeJS module resolution 😅 - I appreciate the research on this! When I have a bit of time I'll play around with...

I don't think removing the `exports` field will solve the issue in this case, though. Even if we remove the `exports` field, the default export is still going to be...

Ah, yes, Typescript. I think the approach then should revolve around [automatically generating a `types.d.ts` at the root of the package,](https://github.com/iconoir-icons/iconoir/issues/243#issuecomment-1443370162) in a way that both Typescript and NextJS are...