Samuel Kirton

Results 25 comments of Samuel Kirton

apt 'com.memtrip.sqlking:preprocessor:1.0.4' needs to be 1.0.6

Great news! I will add appropriate logging like you suggested before closing this issue.

There are no plans to support MacOS, but please feel free to contribute such a change, it would definitely be helpful to other people.

Hi Adrian, Could you review the inner join test at: https://github.com/memtrip/SQLKing/blob/master/client/src/tests/java/com/memtrip/sqlking/integration/JoinTest.java#L57 The example performs an INNER JOIN on User and Log, in the case of a `one to many` relationship...

The PR looks good mate, could you also add a README on how to use the composites though? Also see: https://github.com/memtrip/SQLKing/blob/master/client/src/tests/java/com/memtrip/sqlking/integration/IndexTest.java For examples of how I was testing whether indexes...

Its looking good mate, I will make a code formatter for us to use though so its consistent. I added one other comment. Cheers, Sam

Thanks for the contribution Adrian, its really nice, could you run the default Intellji formatter over the code? I will then squash the commit and rebase it with master.

Hi Adrian, Is this pull request ready to get merged? I will reformat your code before rebasing it into master, so let me know if you need to add any...

Foreign keys are not supported at the moment, I am developing them as part of the next release

Hi Adrian, That is great to hear! Could you rebase your changes with the latest master? Last week I added changes for Primary Keys. Cheers, Sam